CLOUDP-290847: Remove outdated code #378
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
m1kola
force-pushed
the
CLOUDP-290847-clean-up
branch
from
3647300 to
77c55dc
Compare
m1kola
requested review from
anandsyncs,
viveksinghggits,
lsierant and
lucian-tosa
|
LGTM: Ideally removing the code should have failed some existing tests. |
m1kola
added
the
skip-changelog
@anandsyncs this is the code branch we never reach because we do not use/set annotations on the pod template. It seems like leftovers from the previous implementation. Not harming anything by being there apart from the fact it creates a reference to things I'm touching while working on a fix for agent certs rotation. |
lsierant
reviewed
Aug 28, 2025
lsierant
reviewed
Aug 28, 2025
lsierant
reviewed
Aug 28, 2025
lsierant
approved these changes
Aug 28, 2025
anandsyncs
approved these changes
Aug 28, 2025
This piece of code is meant to preserve cert hash annotation in the pod template. We currently do not use cert hash annotation on the pod: we only use sts level annotations.
m1kola
force-pushed
the
CLOUDP-290847-clean-up
branch
from
81549d8 to
9c44512
Compare
|
Rebased on top of No other changes. |
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This piece of code is meant to preserve cert hash annotation in the pod template. We currently do not use cert hash annotation on the pod: we only use sts level annotations.
Proof of Work
Tests must pass
Checklist
skip-changeloglabel if not needed